Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error when stdout or stderr is not writable #1175

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Raise error when stdout or stderr is not writable #1175

merged 1 commit into from
Dec 21, 2016

Conversation

jemiam
Copy link
Contributor

@jemiam jemiam commented Dec 14, 2016

This PR make you detect wrong arguments for stdout_redirect option easily.

@evanphx
Copy link
Member

evanphx commented Dec 21, 2016

This is incorrect as it's not uncommon to allow puma to make those files when it needs them.

@evanphx evanphx closed this Dec 21, 2016
@evanphx evanphx reopened this Dec 21, 2016
@evanphx
Copy link
Member

evanphx commented Dec 21, 2016

Oh der. I misread the patch, it's checking that the directory exists.

@evanphx evanphx merged commit 0b62a39 into puma:master Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jemiam @evanphx